Skip to content

Remove std scheme - #2828

Merged
DavyLandman merged 46 commits into
mainfrom
feature/2817-remove-std-scheme/2819-pathconfig
Sep 2, 2026
Merged

Remove std scheme#2828
DavyLandman merged 46 commits into
mainfrom
feature/2817-remove-std-scheme/2819-pathconfig

Conversation

@toinehartman

@toinehartman toinehartman commented Jul 16, 2026

Copy link
Copy Markdown
Member

Closes #2819.
Closes #2821.
Closes #2820.
Closes #2825.
Closes #2822.
Closes #2830.

toinehartman and others added 2 commits July 15, 2026 11:17
Part of #2819.

Co-authored-by: Rodin Aarssen <rodin.aarssen@swat.engineering>
@toinehartman toinehartman self-assigned this Jul 16, 2026
@codecov

codecov Bot commented Jul 16, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 41.17647% with 50 lines in your changes missing coverage. Please review.
✅ Project coverage is 45%. Comparing base (d7291c4) to head (662adb2).
⚠️ Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
src/org/rascalmpl/library/util/PathConfig.java 39% 20 Missing and 9 partials ⚠️
src/org/rascalmpl/uri/URIUtil.java 35% 5 Missing and 4 partials ⚠️
src/org/rascalmpl/library/util/Reflective.java 40% 2 Missing and 1 partial ⚠️
...c/org/rascalmpl/shell/AbstractCommandlineTool.java 0% 2 Missing ⚠️
src/org/rascalmpl/shell/ShellEvaluatorFactory.java 50% 2 Missing ⚠️
...rascalmpl/uri/file/MavenRepositoryURIResolver.java 33% 1 Missing and 1 partial ⚠️
...nterpreter/load/SourceLocationListContributor.java 0% 1 Missing ⚠️
...ascalmpl/repl/completers/RascalQualifiedNames.java 0% 1 Missing ⚠️
...mpl/uri/remote/jsonrpc/SourceLocationResponse.java 0% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##              main   #2828   +/-   ##
=======================================
  Coverage       45%     45%           
+ Complexity    6807    6801    -6     
=======================================
  Files          844     843    -1     
  Lines        68785   68796   +11     
  Branches     10023   10030    +7     
=======================================
+ Hits         31365   31374    +9     
- Misses       35047   35049    +2     
  Partials      2373    2373           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@toinehartman

toinehartman commented Jul 16, 2026

Copy link
Copy Markdown
Member Author

toinehartman and others added 5 commits July 15, 2026 10:32
This removes `std://` locations in the published Rascal JARs, in favor
of `mvn://` pointing to this specific released version. Closes #2820.

Closes #2820.
Co-authored-by: Rodin Aarssen <rodin.aarssen@swat.engineering>
Part of #2819.

Co-authored-by: Rodin Aarssen <rodin.aarssen@swat.engineering>
Closes #2821.

Co-authored-by: Rodin Aarssen <rodin.aarssen@swat.engineering>
@toinehartman
toinehartman force-pushed the feature/2817-remove-std-scheme/2819-pathconfig branch from 47dfb34 to aac53b3 Compare July 17, 2026 10:12
@toinehartman
toinehartman changed the base branch from feature/2817-remove-std-scheme/final to main July 17, 2026 10:16
@toinehartman toinehartman changed the title Remove std scheme from path configs Remove std scheme Jul 17, 2026
This was referenced Jul 17, 2026
@toinehartman
toinehartman force-pushed the feature/2817-remove-std-scheme/2819-pathconfig branch from 5dbea58 to 34d136f Compare July 17, 2026 10:51
toinehartman and others added 2 commits July 17, 2026 12:58
Closes #2825.

Co-authored-by: Rodin Aarssen <rodin.aarssen@swat.engineering>
Closes #2822.

Co-authored-by: Rodin Aarssen <rodin.aarssen@swat.engineering>
@toinehartman
toinehartman force-pushed the feature/2817-remove-std-scheme/2819-pathconfig branch from 34d136f to 64173b4 Compare July 17, 2026 11:00
@toinehartman
toinehartman force-pushed the feature/2817-remove-std-scheme/2819-pathconfig branch 2 times, most recently from 3a90d49 to 6d18180 Compare July 28, 2026 16:17
@toinehartman
toinehartman force-pushed the feature/2817-remove-std-scheme/2819-pathconfig branch from c7b7463 to 673001d Compare August 26, 2026 06:50
@toinehartman
toinehartman force-pushed the feature/2817-remove-std-scheme/2819-pathconfig branch from e3bf3e2 to 4c9b303 Compare August 26, 2026 15:00
@toinehartman

toinehartman commented Aug 26, 2026

Copy link
Copy Markdown
Member Author

Rebased this branch to get rid of some ugly commits and all the intermediate release stuff. There were some reverted commits and an attempt to exclude those from git blame. Rebased and force-pushed from e3bf3e2 to 8a9150c. Proof that nothing changed unintentionally:

$ git diff e3bf3e2 8a9150c
diff --git a/.git-blame-ignore-revs b/.git-blame-ignore-revs
index eb431e4e11..d556b15bdc 100644
--- a/.git-blame-ignore-revs
+++ b/.git-blame-ignore-revs
@@ -14,7 +14,3 @@ a004c2604cef592975f60a572c4a03491b2f7971
 # Revert and re-application of a merge commit
 3d5369b35a00bddc085d722010baf329580b1c68
 b277ae88b653f039b576717f8d9ecd56e5dbd2fe
-
-# Reverts of commits
-9775112e739b03fb292f01d5303d50031e267322
-371fec8d66014bf75f46937ad67633190ac6037b

After the rebase, I added 4c9b303 (which does introduce changes). Therefore, the force-push shows that commit as endpoint.

@rodinaarssen
rodinaarssen force-pushed the feature/2817-remove-std-scheme/2819-pathconfig branch from f92f486 to 1584353 Compare September 2, 2026 11:34
@sonarqubecloud

sonarqubecloud Bot commented Sep 2, 2026

Copy link
Copy Markdown

@DavyLandman
DavyLandman merged commit 95b16df into main Sep 2, 2026
11 of 14 checks passed
DavyLandman added a commit to usethesource/rascal-language-servers that referenced this pull request Sep 3, 2026
Companion to usethesource/rascal#2828

Closes #1151.
Closes #1147.
Closes #1148.
Closes #1149.
Closes #1027.

Includes the following PRs:
- #1163 
- #1168 
- #1169 
- #1185 
- #1189
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment